Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pseudo-Voigt: Compound Model or functional_models #16021

Open
Ajb2307 opened this issue Feb 9, 2024 · 2 comments
Open

Pseudo-Voigt: Compound Model or functional_models #16021

Ajb2307 opened this issue Feb 9, 2024 · 2 comments

Comments

@Ajb2307
Copy link

Ajb2307 commented Feb 9, 2024

What is the problem this feature will solve?

The “Pseudo-Voigt” equation is a linear combination of the Gaussian profile and Lorentzian function. It offers a less complex alternative to the Voigt function and gives the user parameters of the mixing coefficient between Gaussian profile and Lorentzian function, equivalent width, and depth of the feature.

We found it the best option for evaluating alkali absorption lines in the near-infrared, but it is currently unavailable on Astropy (see poster linked below)

Describe the desired outcome

This could be added to AstroPy in Compound Model or functional_models as there is significant use of this model in the astronomical community and is a natural progression of AstroPy's modeling tools that already include the Voigt profile, Gaussian profile, and Lorentzian Function.

Additional context

https://aas243-aas.ipostersessions.com/Default.aspx?s=FA-8F-E2-DC-BE-FF-45-08-3E-48-E5-33-FC-E3-B1-E6

Copy link

github-actions bot commented Feb 9, 2024

Welcome to Astropy 👋 and thank you for your first issue!

A project member will respond to you as soon as possible; in the meantime, please double-check the guidelines for submitting issues and make sure you've provided the requested details.

GitHub issues in the Astropy repository are used to track bug reports and feature requests; If your issue poses a question about how to use Astropy, please instead raise your question in the Astropy Discourse user forum and close this issue.

If you feel that this issue has not been responded to in a timely manner, please send a message directly to the development mailing list. If the issue is urgent or sensitive in nature (e.g., a security vulnerability) please send an e-mail directly to the private e-mail feedback@astropy.org.

@pllim pllim added the modeling label Feb 9, 2024
@pllim
Copy link
Member

pllim commented Feb 9, 2024

Thanks for the idea! Sounds reasonable if someone wants to propose a PR to implement this (along with tests). I think this falls under a very old discussions in #981 to expand modeling to include other useful models.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants