Remove an erroneous special case from search_around_3d()
#16280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`search_around_3d()` expects the search radius to be a length and it expects its input coordinates to have physical distances (i.e. not with the unit `dimensionless_unscaled`). If that is not the case a `UnitConversionError` is raised, unless at least one of the coords is empty. The new tests reveal the erroneous special case.
The function now raises the expected `UnitConversionError` if the units of the distances of the input coordinates and the search limit do not agree even if one of the input coordinates is empty.
|
Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.
|
mhvk
approved these changes
Apr 9, 2024
|
I think the readthedocs failure has been solved, but perhaps that is not quite worth running all CI again for - so, maybe @pllim can wave the magic merge wand? |
|
Sorry for the delay. I was away watching a rock passing in front of a ball of gas. 😆 |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
Wasn't it just spectacular?!! |
eerovaher
pushed a commit
to eerovaher/astropy
that referenced
this pull request
Apr 12, 2024
…rch_around_3d()` Cherry picked from commit 9dff116
1 task
eerovaher
pushed a commit
to eerovaher/astropy
that referenced
this pull request
Apr 12, 2024
…rch_around_3d()` Cherry picked from commit 9dff116
pllim
added a commit
that referenced
this pull request
Apr 12, 2024
Backport PR #16280 on branch v6.1.x (Remove an erroneous special case from search_around_3d())
Yes!!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In
search_around_3d()ifcoord1.distance,coord2.distanceanddistlimithave incompatible units (e.g.distlimitis a length, butcoords1orcoords2has a distance withdimensionless_unscaled) then it will raise anUnitConversionError, unless at least one of the input coordinates is empty. I cannot think of a good reason why such a special case should exist, and in some cases this behavior can be the cause of aUnitConversionErrorsomewhere else in the code, depending on what the unit ofcoords1.distanceis.I expect the automatic backport to fail because of recent changes to the tests.