Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get_sun returns vector solution for single time #3998

Closed
bmorris3 opened this issue Jul 22, 2015 · 2 comments · Fixed by #4039
Closed

get_sun returns vector solution for single time #3998

bmorris3 opened this issue Jul 22, 2015 · 2 comments · Fixed by #4039
Assignees
Milestone

Comments

@bmorris3
Copy link
Contributor

@eteq : Is this intended behavior? Shouldn't get_sun return a scalar sky coordinate for a scalar time?

>>> time = Time.now()
>>> time.isscalar
True
>>> sun = get_sun(time)
>>> sun.isscalar
False
>>> sun[0]
<SkyCoord (GCRS: obstime=2015-07-22 22:39:14.781846, obsgeoloc=[ 0.  0.  0.] m, obsgeovel=[ 0.  0.  0.] m / s):39:14.781846, obsgeoloc=[ 0.  0.  0.] m, obsgeovel=[ 0.  0.  0.] m / s): (ra, dec, distance) in (deg, deg, AU)
    (122.76730836, 20.02852949, 1.01598715)>
@eteq eteq self-assigned this Jul 22, 2015
@eteq eteq added this to the v1.0.4 milestone Jul 22, 2015
@eteq
Copy link
Member

eteq commented Jul 22, 2015

Hmm, this is definitely not intended, and appears to be a regression in v1.0.3 (i.e., it's correct in v1.0-v1.0.2).

Cant help but think it might be related to #3920 somehow...

@eteq
Copy link
Member

eteq commented Jul 22, 2015

I bet it's somehow caused by #3750, which was between v1.0.2 and 1.0.3 and touched the relevant functionality - will investigate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants