Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 1.1.2 with WCSLIB 5.14 and also 1.0.9 #4613

Closed
3 tasks done
astrofrog opened this issue Feb 18, 2016 · 11 comments
Closed
3 tasks done

Release 1.1.2 with WCSLIB 5.14 and also 1.0.9 #4613

astrofrog opened this issue Feb 18, 2016 · 11 comments
Milestone

Comments

@astrofrog
Copy link
Member

As described in #4579 (comment), there is a major bug in the WCSLIB bundled with Astropy 1.1 and 1.1.1 which caused #4612. This is fixed in master by #4579 but should be backported to the 1.1.x and we should then release 1.1.2, since this is a bad bug (CRVAL1 gets truncated to ~arcminute precision!).

cc @keflavich @nden @eteq

@eteq
Copy link
Member

eteq commented Feb 18, 2016

That sounds good to me!

@nden
Copy link
Contributor

nden commented Feb 18, 2016

wcslib-5.14 bundled in #4579 also fixes #4555. There's some additional work to be done in order to propagate the flags to/from astropy.wcs to wcslib. Since it's essentially the same type of problem it would be nice to fix it now. Does anyone have time to look into this?

@eteq
Copy link
Member

eteq commented Feb 19, 2016

@astrofrog - I've double checked and 1.0.8 seems to show none of these precision-bouncing effects.

@astrofrog
Copy link
Member Author

See #4619 for a clarification of the changelog and another regression test.

@eteq
Copy link
Member

eteq commented Feb 26, 2016

Note that everything that should be seems to be backported to v1.1.x now, and the only holdout is that #4561 needs to get in to restore py2.6 compatibility.

@astrofrog
Copy link
Member Author

@eteq - you mean #4641 right?

@eteq
Copy link
Member

eteq commented Feb 29, 2016

Oops, yeah, meant #4641 (which is a fix for #4561)

@eteq
Copy link
Member

eteq commented Feb 29, 2016

@astrofrog - OK, I think everything is backported that should be for 1.0.x and 1.1.x. And v1.1.x is passing: https://travis-ci.org/astropy/astropy/builds/112699046

We do need to do some changelog cleanup, though. I also think it would make sense to try to get #4650 in before a release, as it fixes some unintended consequences beyond astropy that were reported in #4633.

@eteq
Copy link
Member

eteq commented Mar 1, 2016

Also now v1.0.x is passing following a changelog tweak: https://travis-ci.org/astropy/astropy/builds/112746614

@eteq eteq changed the title Release 1.1.2 with WCSLIB 5.14 Release 1.1.2 with WCSLIB 5.14 and also 1.0.9 Mar 2, 2016
@eteq eteq added the Release label Mar 2, 2016
@eteq
Copy link
Member

eteq commented Mar 2, 2016

Current TBD before release:

Note that I also changed the title to do 1.0.9 at the same time. That will make the changelog easier anyway.

@eteq eteq added this to the v1.1.2 milestone Mar 10, 2016
@eteq
Copy link
Member

eteq commented Mar 10, 2016

1.1.2 released! https://pypi.python.org/pypi/astropy/1.1.2

@eteq eteq closed this as completed Mar 10, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants