Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve fitting of broken power-law models #6221

Open
astrofrog opened this issue Jun 15, 2017 · 0 comments
Open

Improve fitting of broken power-law models #6221

astrofrog opened this issue Jun 15, 2017 · 0 comments

Comments

@astrofrog
Copy link
Member

As discussed in #6198, the broken power-law models may behave better when fitting if parametrized with log_x_break instead of x_break. There are several options:

  1. Change both models to log_x_break and deprecate x_break
  2. Make it possible to describe the model with x_break and use log_x_break internally
  3. Implement two versions of the model, one with x_break and one with log_x_break (this could be done with minimal code duplication).
  4. Make it so that Parameters can indicate whether to be fit in log space (or according to other functions)

@gcalderone suggested that 3 might be the easiest to do. Just opening this issue so that we remember to do it for the next version.

(I'd also like to see examples where the log version would work and the non-log version fails, to make sure we really need this)

@astrofrog astrofrog added this to the v3.0.0 milestone Jun 15, 2017
@bsipocz bsipocz modified the milestones: v3.0.0, v3.1 Jan 15, 2018
@bsipocz bsipocz removed this from the v3.1 milestone Oct 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants