Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revisit workarounds and skipped tests when numpy-1.14.2 is available #7258

Closed
drdavella opened this issue Mar 2, 2018 · 2 comments · Fixed by #7471
Closed

Revisit workarounds and skipped tests when numpy-1.14.2 is available #7258

drdavella opened this issue Mar 2, 2018 · 2 comments · Fixed by #7471
Labels
numpy-dev testing
Projects
3.1 Feature Planning

Comments

@drdavella
Copy link
Contributor

PR #7234 fixed the numpy-related test failures that were documented in #7214. However, some of these changes were just temporary workarounds or skipped tests, so they should be addressed once numpy-1.14.2 is released (assuming it actually fixes these issues).
@pllim pllim added this to Needs decision in 3.1 Feature Planning Mar 2, 2018
@astrofrog
Copy link
Member

I wonder if it would make sense to xfail those tests only for NUMPY_EQ_141 so that this automatically triggers failures when Numpy 1.14.2 is out.

@pllim
Copy link
Member

pllim commented Mar 9, 2018

#7267 and #7276 addressed everything except for docs/io/fits/usage/unfamiliar.rst.

@pllim pllim mentioned this issue Mar 9, 2018
Merged
@bsipocz bsipocz mentioned this issue May 16, 2018
Merged
@pllim pllim moved this from Needs decision to Done in 3.1 Feature Planning Jun 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
numpy-dev testing
Projects
No open projects
3.1 Feature Planning
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Removing doctest-skip workaround for np 1.14.1 bsipocz/astropy
3 participants
@astrofrog @pllim @drdavella