Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v2.0.x : Fix None return annotation in quantity_input #7380

Merged
merged 1 commit into from Apr 20, 2018

Conversation

Cadair
Copy link
Member

@Cadair Cadair commented Apr 16, 2018

This is a backport of #7336

@astropy-bot
Copy link

astropy-bot bot commented Apr 16, 2018

Hi there @Cadair 👋 - thanks for the pull request! I'm just a friendly 🤖 that checks for issues related to the changelog and making sure that this pull request is milestoned and labeled correctly. This is mainly intended for the maintainers, so if you are not a maintainer you can ignore this, and a maintainer will let you know if any action is required on your part 😃.

I noticed the following issue with this pull request:

  • Changelog entry not present (or pull request number missing) and neither the Affects-dev nor the no-changelog-entry-needed label are set

Would it be possible to fix this? Thanks!

If there are any issues with this message, please report them here.

@bsipocz bsipocz added this to the v2.0.6 milestone Apr 19, 2018
@bsipocz
Copy link
Member

bsipocz commented Apr 19, 2018

@Cadair - Please try to rebase as the LTS branch is not up to date with the backports.

Also, this will need the changelog, but that's in from the other PR so I can add the number before the release (the astropy-bot status fail is thus expected and should be ignored).

Once again, in future please do work in master only and rather split up PRs to backportable and non backportable parts rather than open PRs directly to bugfix.

@bsipocz
Copy link
Member

bsipocz commented Apr 20, 2018

The same CI issues are already on the branch, so I'm merging this now. Thanks @Cadair.

@bsipocz bsipocz merged commit 3cb966e into astropy:v2.0.x Apr 20, 2018
@Cadair Cadair deleted the units/quantity-nan branch April 24, 2018 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants