-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider using appdirs for config #8245
Comments
Which raises the question whether it's worth to the addition of another non optional dependency. Pinging @taldcroft and @mhvk. If they are OK with the idea, I'm too. |
Just our of curiosity, how much code would this save? |
Pretty much everything in it's also worth noting that appdirs is a single file, so can easily be copied into tree. I took a quick swing at this here: Cadair@ae1aa4a |
|
I like the idea, though obviously it means that everyone's config/cache are going to move from Note that it does seem one could make similar gains in size by replacing Aside: |
I'd be in favor (including bundling it in astropy/extern for now) It would be nice to find a way to warn users who do have config directories about the change. |
4.0 would be a good time to do this if you want to move the locations. |
I'm on board, given that we bundle it. Also, agree with @pllim that if the config dir changes, it's better do in 4.0. |
Is it worth doing this in the 3.2 release? Or shall we just do it in 4.0 and emit a warning as and when we migrate locations? (not really sure I know what we would do in 3.2, but I just want to check) |
With #8237 in, is this resolved? |
I was excited about this idea at first--it would be great to have a "standard" library for this sort of thing. But upon closer inspection, I think the layout used by appdirs is better suited for things like desktop applications, where (non-developer) users are less likely to be poking around directly in their config directories. In fact, I think this would be a user-hostile change. In particular for MacOS users, and to some extent Windows users as well. For example, MacOS users are already accustomed to, by default, finding all Astropy-related stuff in Having |
Hi humans 馃憢 - this issue was labeled as Close? approximately 7 days ago. If you think this issue should not be closed, a maintainer should remove the Close? label - otherwise, I will close this issue in a month. If you believe I commented on this issue incorrectly, please report this here |
The bot forgot to close this issue so... I'll proceed. |
@astrofrog (a.k.a. "Helen") should look into the cron job for the bot. Maybe it's not working... |
Rather than re-implementing all the logic of finding the platform specific location for config files, we should just use https://github.com/ActiveState/appdirs 馃榾
@eteq
The text was updated successfully, but these errors were encountered: