Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SSL certificate on docs.astropy.org #8569

Open
saimn opened this issue Apr 11, 2019 · 14 comments
Open

SSL certificate on docs.astropy.org #8569

saimn opened this issue Apr 11, 2019 · 14 comments
Assignees
Labels

Comments

@saimn
Copy link
Contributor

saimn commented Apr 11, 2019

Following #8562, I noticed that there is no ssl certificate for docs.astropy.org (this is the only http url in my intersphinx settings) : https://docs.astropy.org/en/stable/
And actually readthedocs supports this, I just did the change for another custom domain: https://docs.readthedocs.io/en/stable/custom_domains.html#custom-domain-ssl

What is needed is to change the CNAME DNS record to readthedocs.io., instead of astropy.readthedocs.org., and then in readthedocs settings, revalidate the custom domain.

@saimn saimn added the Docs label Apr 11, 2019
@bsipocz
Copy link
Member

bsipocz commented Apr 11, 2019

I'm not exactly sure where to changed that record, the following is what I see on the admin page:

Screen Shot 2019-04-11 at 09 32 26

Note the "Always use HTTPS for this domain" at the bottom, that was unclicked. Let's see whether it has any effect on the issue.

@saimn
Copy link
Contributor Author

saimn commented Apr 11, 2019

I would not check this currently, first someone needs to modify the DNS records, otherwise readthedocs will not build the certificate.

❯ dig docs.astropy.org

...

;; ANSWER SECTION:
docs.astropy.org.	670	IN	CNAME	astropy.readthedocs.org.
astropy.readthedocs.org. 300	IN	A	23.100.69.251

The CNAME must be changed to readthedocs.io., by someone who has access to the domain registar.

@bsipocz
Copy link
Member

bsipocz commented Apr 11, 2019

Oh, ok, fair enough, this case I got the wrong end of the stick (and I don't think I have access to the DNS records).

@pllim
Copy link
Member

pllim commented Apr 11, 2019

I bet it is @astrofrog or @perrygreenfield .

@perrygreenfield
Copy link
Member

I don't think I do.

@hamogu
Copy link
Member

hamogu commented Apr 12, 2019

Whatever the setting is currently, Firefox blocks me from accessing the docs because "docs.astropy.org uses an invalid security certificate."
Screenshot from 2019-04-12 13-49-13

I'll add an exception for myself and hoping that nobody tries to serve me a fake documentation in the interest of screwing up me research ;-)

@bsipocz
Copy link
Member

bsipocz commented Apr 12, 2019

@hamogu - yes, apparently we need to change our DNS entry setting to readthedocs.io, so we can use RTD's certificate. Not yet sure who the person with access to those settings is.
Maybe @eteq and/or @astrofrog.

@eteq
Copy link
Member

eteq commented Apr 12, 2019

I am the keeper of the DNS config. I just followed the steps @saimn and @bsipocz pointed to on the RTD config and in our DNS service, and if I did it all correctly we should be up and running in an hour or so once the SSL certificates get re-issued. If not... I'll troubleshoot further.

@astrofrog
Copy link
Member

It looks like https://docs.astropy.org/en/stable/ works!

@pllim
Copy link
Member

pllim commented Apr 13, 2019

👏 Thanks, @eteq !

@pllim pllim closed this as completed Apr 13, 2019
@eteq
Copy link
Member

eteq commented Apr 15, 2019

Hooray! I'm going to go ahead and close this then, since it's been 24 hours which is usually enough time for everything to propagate. @saimn, feel free to re-open if it's still not working for you though.

@saimn
Copy link
Contributor Author

saimn commented Apr 15, 2019

It works, thanks @eteq !

@mhvk
Copy link
Contributor

mhvk commented Jul 24, 2019

As noted in #9032 (comment), the same SSL certificate stuff may be needed for devdocs

@pllim pllim reopened this Jul 24, 2019
@pllim
Copy link
Member

pllim commented Jul 24, 2019

Okay, I re-opened this issue until we can sort out the devdocs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

8 participants