-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Testmatrix: Add a build where C extensions are compiled without optimizations #8994
Comments
Good idea to have a debug build - in numpy those often found bugs. Presumably we can convert one of the regular builds (coverage sounds good) |
@astrofrog @pllim - this is one of those |
Re: new label -- @bsipocz , I thought we used to have a "domain expert" label but I don't see it now. |
Currently our coverage build does use |
Domain expert isn't the right one though, that was more for astronomy expertise. Maybe having something like |
technical-expert? not really the right one either. |
The issue in #8986 is probably something that we should've catched with out CI. The problem there was that the implementation assumed that the function is always going to be inlined, however when there is a debug build or when the compiler decides not to inline it then the code is going to fail.
I assumed that we used debug builds for the C coverage report but given that these didn't fail we probably have at least some optimizations "on" there.
The text was updated successfully, but these errors were encountered: