Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only draw the axislabel on an spine if there are tick labels to draw #9481

Open
Cadair opened this issue Oct 25, 2019 · 2 comments
Open

Only draw the axislabel on an spine if there are tick labels to draw #9481

Cadair opened this issue Oct 25, 2019 · 2 comments

Comments

@Cadair
Copy link
Member

Cadair commented Oct 25, 2019

This is especially noticeable with the changes in #9392, but if we are not drawing any tick labels on a spine, we shouldn't draw the axis label on that spine either. This prevents the case where you have misconfigured WCSAxes to draw labels on one spine and ticks on the other, and the resulting plot is very confusing!

@Cadair Cadair changed the title Only draw the axislabel on an axis if there are tick labels to draw Only draw the axislabel on an spine if there are tick labels to draw Oct 25, 2019
@bsipocz
Copy link
Member

bsipocz commented Oct 25, 2019

bug or feature?

@Cadair
Copy link
Member Author

Cadair commented Oct 26, 2019

It's a close call, but bug personally.

@bsipocz bsipocz added the Bug label Oct 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants