-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Significant increase in import time for several sub-packages #9555
Comments
For coordinates, one should also review whether that same PR sped up other stuff or not. If it sped up some calculations significantly, import time increase is a small price to pay. Unfortunately, no benchmark is available for |
@astrofrog - not completely sure, but the problem with the auto-update of the leap seconds is that the moment you use any time (like setting the
Personally, I prefer (3), but this may not be trivial either; @taldcroft and @MSeifert04 did quite a nice job to make the reader registration and docstring autogeneration work, but perhaps it can somehow be done more lazily. |
I haven't had time to look but what in |
|
Regarding:
it just occurred to me that one way around this would be to actually move all the |
That sounds very reasonable, though probably good to check the timing (IIRC that is quite easy with python 3.7), just to be sure it is in fact For |
It looks like there has been a significant (~40%) increase in import time for several sub-packages recently:
https://www.astropy.org/astropy-benchmarks/#imports.timeraw_import_astropy_coordinates
https://www.astropy.org/astropy-benchmarks/#imports.timeraw_import_astropy_nddata
asv seems to suggest that #9365 is the cause (cc @mhvk @eteq ).
Interestingly astropy.time also saw such an increase:
https://www.astropy.org/astropy-benchmarks/#imports.timeraw_import_astropy_time
but that was then fixed in #9491.
The text was updated successfully, but these errors were encountered: