Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix name of RingNode class #2896

Closed
matthewtiscareno opened this issue Dec 11, 2023 · 5 comments
Closed

Fix name of RingNode class #2896

matthewtiscareno opened this issue Dec 11, 2023 · 5 comments
Labels
Milestone

Comments

@matthewtiscareno
Copy link

The name of the RingNode class refers to the PDS Ring-Moon Systems Node (of which I'm the manager), commonly abbreviated as the RMS Node. Our previous name was the PDS Rings Node. The current class name is incorrect. Our first preference would be RMSNode, and second preference would be RingsNode.

All references to the RMS Node in documentation should also be updated.

@bsipocz bsipocz added this to the v0.4.7 milestone Dec 12, 2023
@bsipocz bsipocz added the pds label Dec 12, 2023
@bsipocz
Copy link
Member

bsipocz commented Dec 12, 2023

We can do a rename and it doesn't have to come with a deprecation if done before v0.4.7 is tagged (so in the coming few weeks).

cc @emolter

@emolter
Copy link
Contributor

emolter commented Dec 15, 2023 via email

@bsipocz
Copy link
Member

bsipocz commented Dec 15, 2023

at AGU? too bad I didn't manage to get my travel sorted out :(

emolter added a commit to emolter/astroquery that referenced this issue Dec 18, 2023
@emolter
Copy link
Contributor

emolter commented Dec 18, 2023

yes, Matt and I were at AGU and we discussed this change there. Please let me know if this looks good to you

bsipocz added a commit that referenced this issue Dec 19, 2023
rename ring node to RMS node to fix issue #2896
@bsipocz
Copy link
Member

bsipocz commented Dec 19, 2023

Fixed in #2900

@bsipocz bsipocz closed this as completed Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants