-
-
Notifications
You must be signed in to change notification settings - Fork 393
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix name of RingNode class #2896
Comments
We can do a rename and it doesn't have to come with a deprecation if done before v0.4.7 is tagged (so in the coming few weeks). cc @emolter |
Thanks Brigitta, I will work on it early next week - I'm at a conference
this week
…On Mon, Dec 11, 2023 at 5:10 PM Brigitta Sipőcz ***@***.***> wrote:
We can do a rename and it doesn't have to come with a deprecation if done
before v0.4.7 is tagged (so in the coming few weeks).
cc @emolter <https://github.com/emolter>
—
Reply to this email directly, view it on GitHub
<#2896 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AFB2PBSZE54VOU5BDJDWJQLYI6VINAVCNFSM6AAAAABAQNUCHWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNJRGE2DKMZYHE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
at AGU? too bad I didn't manage to get my travel sorted out :( |
emolter
added a commit
to emolter/astroquery
that referenced
this issue
Dec 18, 2023
yes, Matt and I were at AGU and we discussed this change there. Please let me know if this looks good to you |
bsipocz
added a commit
that referenced
this issue
Dec 19, 2023
rename ring node to RMS node to fix issue #2896
Fixed in #2900 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The name of the
RingNode
class refers to the PDS Ring-Moon Systems Node (of which I'm the manager), commonly abbreviated as the RMS Node. Our previous name was the PDS Rings Node. The current class name is incorrect. Our first preference would beRMSNode
, and second preference would beRingsNode
.All references to the RMS Node in documentation should also be updated.
The text was updated successfully, but these errors were encountered: