Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename ring node to RMS node to fix issue #2896 #2900

Merged
merged 1 commit into from
Dec 19, 2023

Conversation

emolter
Copy link
Contributor

@emolter emolter commented Dec 18, 2023

No description provided.

Copy link

codecov bot commented Dec 18, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (5600762) 67.23% compared to head (a8d85fe) 67.23%.

Files Patch % Lines
astroquery/solarsystem/pds/core.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2900   +/-   ##
=======================================
  Coverage   67.23%   67.23%           
=======================================
  Files         235      235           
  Lines       18155    18155           
=======================================
  Hits        12207    12207           
  Misses       5948     5948           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@bsipocz bsipocz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good, thank you!

CHANGES.rst Outdated
@@ -66,6 +66,7 @@ solarsystem.pds
^^^^^^^^^^^^^^^

- New module to access the Planetary Data System's Ring Node System. [#2358]
- Rename from ringnode to ring-moon systems node [#2900]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need for changelog as this only affects the dev version (I can remove the commit before merging, no todo on your side)

@bsipocz bsipocz merged commit a725c7a into astropy:main Dec 19, 2023
16 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants