eJWST release #2238
eJWST release #2238
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2238 +/- ##
==========================================
+ Coverage 62.20% 62.38% +0.17%
==========================================
Files 131 131
Lines 16772 16777 +5
==========================================
+ Hits 10433 10466 +33
+ Misses 6339 6311 -28
Continue to review full report at Codecov.
|
astroquery/esa/jwst/core.py
Outdated
| @@ -1239,4 +1241,7 @@ def get_decoded_string(str): | |||
| return str | |||
|
|
|||
|
|
|||
| Jwst = JwstClass() | |||
| if "pytest" in sys.modules: | |||
There was a problem hiding this comment.
I don't think it's right to have this here in the main code, all testing stuff should be handled in the test files.
There was a problem hiding this comment.
I agree with you, I was thinking on how to avoid connection errors on this, now I have found a workaround using try/except in get_status_messages method
Co-authored-by: Brigitta Sipőcz <b.sipocz@gmail.com>
|
Hi @bsipocz, I have solved your comment about pytest in the main code, and added some additional tests. Regarding remote-data tests, as there will be data after launch in the archive, but not right now, we will include them when we have some static datasets to be used in the tests. Please do not hesitate to contact me in case you have further comments. On the other hand, I would like to ask you about the release of v0.4.5, after this code has been merged. When do you think we could have this version available? |
We said it should be out by the launch. Is that still a good timeline? |
|
Thanks @jespinosaar! |
Dear @bsipocz , @keflavich:
Now we are ready for the operational release of eJWST astroquery module, so, as we agreed, I have uploaded the operational URLs. Thanks for your support!