eJWST: remove disclaimer for release #2243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Codecov Report
@@ Coverage Diff @@
## main #2243 +/- ##
=======================================
Coverage 62.38% 62.38%
=======================================
Files 131 131
Lines 16777 16777
=======================================
Hits 10466 10466
Misses 6311 6311 Continue to review full report at Codecov.
|
|
I also added the entry in the changelog, I think the check will be a success when you include the milestone. |
|
Thanks @jespinosaar! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @bsipocz , @keflavich,
This pull request follows #2238, to remove the disclaimer for users, as it is not needed anymore (my fault, I forgot to remove it). As we agreed, release of v0.4.5 should be out by launch, but, at least from our side, you can start right after this pull request is merged to ensure we can solve any unrelated issue and, if they do not appear, everything will be ready even before launch. Everything is in place in this module.
Kind regards and again, many thanks for your help.
Javi