-
-
Notifications
You must be signed in to change notification settings - Fork 390
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
astroquery.mast
: adding GALEX mission Cloud support
#2261
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2261 +/- ##
==========================================
- Coverage 62.75% 62.74% -0.01%
==========================================
Files 130 130
Lines 16835 16837 +2
==========================================
Hits 10564 10564
- Misses 6271 6273 +2
Continue to review full report at Codecov.
|
Preventing file skip shows that the issue is in
And yeah, it just looks like the data isn't there yet:
The test below shows
A separate issue is how the
astroquery/astroquery/mast/observations.py Line 547 in 27515e4
Then astroquery/astroquery/mast/cloud.py Line 160 in 27515e4
Which feeds it into astroquery/astroquery/mast/cloud.py Line 180 in 27515e4
But astroquery/astroquery/mast/cloud.py Line 96 in 27515e4
Which is why I'm getting the |
It's not much help for you for this PR, but ultimately I think we need to make these download functions a bit more generic/ or rewrite them and put into |
90eade3
to
f68d01e
Compare
I think this is ready to go. Based on convos with the team, it sounds like this is a high priority one, so should take precedent over #2279 . Thanks! |
astroquery.mast
: adding GALEX mission Cloud supportastroquery.mast
: adding GALEX mission Cloud support
… download. this will ensure there are GALEX results in the db queries and that cloud functionality is up to date.
… cloud.py and download the proper file. updating style and format and added a changelog entry.
Thanks @jaymedina! |
Adding cloud support for the GALEX mission.