Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PLATO to Catalogs #2279

Merged
merged 2 commits into from
Feb 19, 2022
Merged

Add PLATO to Catalogs #2279

merged 2 commits into from
Feb 19, 2022

Conversation

jaymedina
Copy link
Contributor

@jaymedina jaymedina commented Feb 3, 2022

Functionality: Following the latest MAST patch, this PR adds PLATO as a query option to astroquery.mast.Catalogs.query_region and query_object.

Documentation: mast.rst is updated to reflect new PLATO DR1 availability.

Testing: test_mast_remote.py is updated with a regression test for PLATO query.

@jaymedina jaymedina marked this pull request as draft February 3, 2022 21:47
@jaymedina jaymedina self-assigned this Feb 3, 2022
@codecov
Copy link

codecov bot commented Feb 3, 2022

Codecov Report

Merging #2279 (5e7358f) into main (5740dc7) will decrease coverage by 0.00%.
The diff coverage is 33.33%.

❗ Current head 5e7358f differs from pull request most recent head 03eca88. Consider uploading reports for the commit 03eca88 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2279      +/-   ##
==========================================
- Coverage   62.74%   62.73%   -0.01%     
==========================================
  Files         130      130              
  Lines       16837    16840       +3     
==========================================
+ Hits        10564    10565       +1     
- Misses       6273     6275       +2     
Impacted Files Coverage Δ
astroquery/mast/collections.py 90.25% <33.33%> (-1.85%) ⬇️
astroquery/mast/cloud.py 22.66% <0.00%> (+0.58%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5740dc7...03eca88. Read the comment docs.

@pep8speaks
Copy link

pep8speaks commented Feb 4, 2022

Hello @jaymedina! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2022-02-18 16:27:33 UTC

@jaymedina jaymedina force-pushed the add-plato branch 3 times, most recently from 8712582 to c082e22 Compare February 9, 2022 15:28
@jaymedina jaymedina marked this pull request as ready for review February 9, 2022 15:34
Copy link
Member

@bsipocz bsipocz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments only. Please squash commits though.

CHANGES.rst Outdated Show resolved Hide resolved
astroquery/mast/collections.py Outdated Show resolved Hide resolved
astroquery/mast/collections.py Show resolved Hide resolved
docs/mast/mast.rst Outdated Show resolved Hide resolved
@jaymedina jaymedina force-pushed the add-plato branch 3 times, most recently from 51f3da8 to 4332bc3 Compare February 9, 2022 21:00
…test_mast.py, and updated CHANGES.rst, and other documentation and formatting updates
@bsipocz
Copy link
Member

bsipocz commented Feb 19, 2022

Thanks @jaymedina!

@bsipocz
Copy link
Member

bsipocz commented Feb 19, 2022

(I merge as this was already passing before the squash and the current CI issue seems absolutely upstream related)

@bsipocz bsipocz merged commit 6400d6c into astropy:main Feb 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants