Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NIST: Fetch statistical weight (g) from NIST ASD #2955

Merged
merged 3 commits into from
Feb 23, 2024
Merged

Conversation

mimurrayy
Copy link
Contributor

This PR makes the NIST module fetch the optional parameter g, which is currently not done.
The current NIST tests only check certain parts of the response table and should not be affected by the additional parameter.

Related issue: #2953

Copy link

codecov bot commented Feb 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.80%. Comparing base (1c6b7bf) to head (05192b1).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2955   +/-   ##
=======================================
  Coverage   66.80%   66.80%           
=======================================
  Files         237      237           
  Lines       18320    18321    +1     
=======================================
+ Hits        12238    12239    +1     
  Misses       6082     6082           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bsipocz bsipocz added the nist label Feb 23, 2024
@bsipocz bsipocz added this to the v0.4.7 milestone Feb 23, 2024
Copy link
Member

@bsipocz bsipocz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The result table in the doc has changed with this PR, so I'll push a commit to fix it and then go ahead with the merge.

Thanks @mimurrayy!

@mimurrayy
Copy link
Contributor Author

Ah! I was just trying to figure out why the docs were failing. Thanks @bsipocz !

Copy link
Contributor

@keflavich keflavich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming we have tests in place that are passing (I hope we do...), this lgtm.

@bsipocz
Copy link
Member

bsipocz commented Feb 23, 2024

RTD failure is unrelated (and I'm not exactly sure why it started to show now), so I go ahead and merge this.

(the remote/server reaching tests are turned off by default, you can run them with e.g. pytest -P nist -R)

Thanks again!

@bsipocz bsipocz merged commit 4d23117 into astropy:main Feb 23, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants