Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update VSA url #3033

Merged
merged 2 commits into from
Jun 12, 2024
Merged

Update VSA url #3033

merged 2 commits into from
Jun 12, 2024

Conversation

robertdstein
Copy link
Contributor

The VSA url seems to be outdated (horus.roe.ac.uk rather than vsa.roe.ac.uk). I'm not sure when exactly the URL changed, but navigating in a browser to http://horus.roe.ac.uk will redirect to the new vsa.roe.ac.uk page. At a guess, I'd say this URL change is also why the VSA tests stopped working (#2828).

Anyway, this PR just updates the URL to the new one. Having tested locally, the queries etc now work as expected with the new URL.

Copy link
Member

@bsipocz bsipocz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This indeed fixes the current test failures, so I'll add a short changelog entry and merge it in.

(I'm not sure #2828 was related, that one eventually self resolved)

@bsipocz bsipocz marked this pull request as ready for review June 12, 2024 22:27
@bsipocz bsipocz added this to the v0.4.8 milestone Jun 12, 2024
@bsipocz bsipocz merged commit 4a347cd into astropy:main Jun 12, 2024
1 check passed
@bsipocz
Copy link
Member

bsipocz commented Jun 12, 2024

Thanks @robertdstein!

@robertdstein robertdstein deleted the vsaurl branch June 27, 2024 02:40
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants