Merge pull request #801 from tbowers7/bugfix_empty_ifc

Add check for empty IFC in filtering

CHANGES.rst

@@ -1,3 +1,18 @@
+2.4.1 (unreleased)
+------------------
+
+New Features
+^^^^^^^^^^^^
+
+Other Changes and Additions
+^^^^^^^^^^^^^^^^^^^^^^^^^^^
+
+Bug Fixes
+^^^^^^^^^
+
+- Fixes a crash when attempting to filter an already-empty ImageFileCollection,
+  instead simply returning an empty ImageFileCollection.  [#801]
+
 2.4.0 (2022-11-16)
 ------------------
 

ccdproc/image_collection.py

@@ -366,6 +366,10 @@ def files_filtered(self, **kwd):
         Value comparison is case *insensitive* for strings, whether matching
         exactly or matching with regular expressions.
         """
+        # If the collection is empty, self.summary == None; return empty list
+        if self.summary is None:
+            return []
+
         # force a copy by explicitly converting to a list
         current_file_mask = self.summary['file'].mask.tolist()
 

ccdproc/tests/test_image_collection.py

@@ -1015,6 +1015,7 @@ def test_type_of_empty_collection(self, triage_setup):
             ic = ImageFileCollection(triage_setup.test_dir)
         assert ic.summary is None
         assert ic.keywords == []
+        assert ic.files_filtered() == []
 
     def test_regex_match_for_search(self, triage_setup):
         # Test regex matching in searches