Add a 'sort' method to ImageFileCollection #274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hamogu -- once again, thank you! Could you please add a short mention of this to https://github.com/astropy/ccdproc/blob/master/docs/ccdproc/image_management.rst ? |
|
@bsipocz : "1 failing check": Where did Travis go? It seems we are running only appveyor now? |
This uses the underlying table structure to do that sort, it also updates the separate self._files accordingly. This method allows me to set a the order in which the files are processed, e.g. I can iterate over all files and make plots sorted alphabetically by 'OBJECT' or by 'OBS-TIME' or 'FILTER'. A related chage is to sort the file list when reading files from a directory. This sorting is alphapetical, if the user does not like it they can always use the new 'sort' function later. This change makes the order of files that are read in reproducable, which useful when the iterators are used to make plots of each file - I want the same order when I re-run my script. (Without this change the order of files seems to change randomly at times.)
|
OK, I pushed again and now I see Travis. That may have been a github fluke. |
|
@hamogu - Must have been a glitch. Sometimes there is an annoying delay in picking up the commits. |
|
Docs added. Tests passed. |
crawfordsm
added a commit
that referenced
this pull request
Jan 12, 2016
Add a 'sort' method to ImageFileCollection
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses the underlying table structure to do that sort, it also updates
the separate self._files accordingly.
This method allows me to set a the order in which the files are processed,
e.g. I can iterate over all files and make plots sorted alphabetically by
'OBJECT' or by 'OBS-TIME' or 'FILTER'.
A related change is to sort the file list when reading files from a
directory. This sorting is alphabetical, if the user does not like it
they can always use the new 'sort' function later.
This change makes the order of files that are read in reproducible, which is useful
when the iterators are used to make plots of each file - I want the same order
when I re-run my script.
(Without this change the order of files seems to change randomly at times.)