-
-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding appveyor testing and opting in ci-helpers #273
Adding appveyor testing and opting in ci-helpers #273
Conversation
7d20c58
to
96fbafd
Compare
The Travis test fails, because the pytest plugin pytest-capture log is not installed. Before your PR, that was done manually in Either pip pytest-capture log need to be called by hand (in .travis.yml) or we need to add this package to Note that I have a strong interest to make this PR work, too, because my own PRs #274 and #275 now have failing tests because the appveyor setup is not complete. ;-) |
@hamogu - Sure, I'll make this work in the weekend. It's seems to be trivial to fix, I just didn't have any time today to iron it out (last night the builds were piling up and it was hopeless to wait for them to finish). |
@bsipocz -- I'll try to fix the Windows errors (may need to rewrite tests or mark some as skip on Windows ) if you want to take care of the travis fail...if you want to do Windows too, let me know, I won't stand in the way :) |
Travis is basically fixed, the astropy version number is case sensitive, but I already have the PR in ci-helpers to make it insensitive. The windows failures are a different case, they look genuine and I don't have much windows experience since win98, so can only try and hack around with the help of our mutual friend, google. |
xfailing sounds good. I've looked into the underlying issue before, it has to do with (at least in some of the cases) with overwriting files in Windows. Though the fail happens in io.fits, it is something in |
Do you want me to do the xfails? |
Nope, I already started it. Just waiting for the ci-helpers fix before pushing the commit. |
@mwcraig - This doesn't need a changelog entry, right? Or should the windows testing be mentioned somewhere? |
@bsipocz -- nope, no need for changelog. |
Adding appveyor testing and opting in ci-helpers
This is to address and close #259.
I've also added ccdproc as a project on appveyor itself for astropy.