Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

minor suggestion on lacosmic #347

Closed
wschoenell opened this issue May 11, 2016 · 2 comments · Fixed by #348
Closed

minor suggestion on lacosmic #347

wschoenell opened this issue May 11, 2016 · 2 comments · Fixed by #348

Comments

@wschoenell
Copy link
Contributor

wschoenell commented May 11, 2016 •
edited

Can I suggest to change the default value of the saturation level from satlevel=65536.0 to satlevel=65535.0? All CCDs that I've seen on my life have saturation 65535 which is the maximum unsigned 16 bit value (2^16 - 1).

ccdproc/ccdproc/core.py

Line 1159 in 09d9f60

satlevel=65536.0, pssl=0.0, niter=4,

@crawfordsm
Copy link
Member

Thanks @wschoenell -- if you would like to make a pull request with the change, we would accept it. (and also happy to help you do it). Otherwise, we will make the change first chance we get.

wschoenell added a commit to wschoenell/ccdproc that referenced this issue May 11, 2016
@wschoenell
Fixes astropy#347 by changing default saturation level to 65535 elect…
3b4c270 
…rons

	* 65535 is the more common saturation level on CCDs as it is the maximum unsigned 16 bit value (2^16 - 1).
@wschoenell wschoenell mentioned this issue May 11, 2016
Merged
@wschoenell
Copy link
Contributor Author

Ok. Done.

wschoenell added a commit to wschoenell/ccdproc that referenced this issue May 11, 2016
@wschoenell
Added a CHANGELOG for astropy#347
1f7c133
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Change lacosmic saturation level default to 65535 wschoenell/ccdproc
2 participants
@crawfordsm @wschoenell