Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add dtype argument to combine-function. #392

Merged
merged 2 commits into from
Sep 1, 2016
Merged

add dtype argument to combine-function. #392

merged 2 commits into from
Sep 1, 2016

Conversation

MSeifert04
Copy link
Contributor

@MSeifert04 MSeifert04 commented Aug 24, 2016

Fixes #391

This PR adds a dtype parameter which is passed to Combiner.

This fixes two Bugs:

  • if the dtype of the first ccd passed to combine isn't float64 the result was downcast to the dtype of the first ccd.
  • in that case also the memory consumption calculation was wrong because Combiner used float64 while the calculation assumed the dtype to be the same as the one of the first ccd.

And also allows to optionally reduce the memory consumption by simple using a dtype.

@crawfordsm crawfordsm merged commit 195b400 into astropy:master Sep 1, 2016
@crawfordsm crawfordsm added this to the 1.2 milestone Sep 1, 2016
@MSeifert04 MSeifert04 deleted the dtype_combine branch September 1, 2016 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can I set the dtype of the combined image?
2 participants