Use divide method (and fix a couple errors that uncovered) #116
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main change was intended to fix #92, but it turns out that running the tests of `flat_correct`` with perfectly uniform flats was masking a couple of errors.
One was that the arithmetic methods return a new array, but flat correct was returning the original array. The other was that it isn't always the case that
flat_data.data.mean() == ccd_data.data.mean()
after flat correction, because the mean of a ratio isn't the ratio of the means (though this had me going in circles for about 15 minutes).The tests were also change to
almost_equal
-type tests.