New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Transform #126
Transform #126
Conversation
"""Transform the image | ||
|
||
Using the function specified by transform_func, the transform will | ||
be applied to all planes in ccd. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
By all planes you mean image, mask and uncertainty, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
Several specific comments are above -- this seems like a solid start. A few broad questions:
|
As for transforming uncertainties and masks, there are a small set of cases where they will be handled fine (integer shifts) and then a much larger set of cases where they will have problems (just about anything else). Masks I think are handled correctly, but with the statement that anything that once had a bad pixel in it, now is a bad pixel. That is at least safe even though a more complex algorithm may still be able to handle and still include those pixels. However, I don't think there is anything in existence right now that would handle transforming uncertainty frames correctly and the correlation between the pixels. This will probably be close for most cases, but I think this would be an issue to be improved upon in future versions. |
As for |
It is getting increasingly tempting to not deal with uncertainties at all :) -- it will be useful to hear from users what they want/need. I thought it was likely the case that transforms should be purely geometrical -- sounds good! |
closes #67 and closes #66. Adds transformations of the CCDData object although uncertainties may not be handled correctly. It also handles rebinning of ccddata objects.