Add option to automatically determine the overscan axis #263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR is incomplete, and largely meant as an issue/RFC, with an example implementation. |
evertrol
force-pushed
the
overscan_axis
branch
from
773f37c
to
6da79d4
Compare
|
I guess the failure of Travis here is directly related to #262 ? |
|
Yes, the test failure is related to that, which shouldn't effect the rest of your work. If you want to go ahead and add the doc_string update, a test, and something to the change log that would be great. Thanks for the contribution! |
evertrol
force-pushed
the
overscan_axis
branch
2 times, most recently
from
9711436
to
a06826f
Compare
If the overscan axis is explicitly set to `None` in `subtract_overscan`, the overscan direction is determined from the shape of the overscan section, set the shortest dimension. (In case of a square overscan, the default of 1 is picked.) This can be convenient in cases where `fits_section` is used with an (unknown) input string (for example, from an image's BIASSEC header keyword): the user can let the function determine the appropriate axis.
evertrol
force-pushed
the
overscan_axis
branch
from
a06826f
to
9827729
Compare
crawfordsm
added a commit
that referenced
this pull request
Jan 12, 2016
Add option to automatically determine the overscan axis
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the overscan axis is explicitly set to
Noneinsubtract_overscan, the overscan direction is determined from theshape of the overscan section, set the shortest dimension. (In case of
a square overscan, the default of 1 is picked.)
This can be convenient in cases where
fits_sectionis used with an(unknown) input string (for example, from an image's BIASSEC header
keyword): the user can let the function determine the appropriate
axis.