Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create AUTHORS.rst #313

Merged
merged 1 commit into from
Mar 13, 2016
Merged

Create AUTHORS.rst #313

merged 1 commit into from
Mar 13, 2016

Conversation

souravsingh
Copy link
Contributor

Added a file for Contributors of the Project.

Added a file for Contributors of the Project.
@crawfordsm
Copy link
Member

Thanks @souravsingh. I think we will need to do a clean up of the git log as the commits related to astropy-helpers should probably be removed as they are not direct contributions to ccdproc.

@bsipocz
Copy link
Member

bsipocz commented Feb 26, 2016

@crawfordsm - I don't think it's necessary to hack the log and rewrite history.

The commits are coming from the package-template and not from astropy-helpers. Maybe the easiest would be to cross match the commit hashes against the template. The ones that don't match are ccdproc only.

@bsipocz
Copy link
Member

bsipocz commented Feb 26, 2016

Also, all commits before 9185b8b seems to be coming from the template.

@crawfordsm
Copy link
Member

@souravsingh can you implement @bsipocz suggestion and see what the list returns? All the wording should be updated to reflect this is for ccdproc and not astropy

@souravsingh
Copy link
Contributor Author

@crawfordsm I will get on to it.

@mwcraig
Copy link
Member

mwcraig commented Mar 13, 2016

Merging as-is, will open a separate PR in a few minutes to clean up the list.

mwcraig added a commit that referenced this pull request Mar 13, 2016
@mwcraig mwcraig merged commit eea8678 into astropy:master Mar 13, 2016
@mwcraig
Copy link
Member

mwcraig commented Mar 13, 2016

Thanks, @souravsingh!

@souravsingh souravsingh deleted the issue-213 branch March 13, 2016 18:35
@souravsingh
Copy link
Contributor Author

Thanks for merging the PR @mwcraig

@MSeifert04
Copy link
Contributor

@souravsingh - I think you missed the @ when crediting hamogu

Sorry - I just saw that will be fixed by #322.

@souravsingh souravsingh restored the issue-213 branch March 13, 2016 19:27
@souravsingh souravsingh deleted the issue-213 branch March 13, 2016 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants