Move generation of test directory to utils #700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This passed locally, I swear... |
|
@crawfordsm @MSeifert04 -- could I get a quick review of this? |
|
Just from a quick glance: Can't we now import the |
|
Thanks Matt 👍, I wonder if we really want to make a bugfix release instead of a minor release? |
yeah, thought I had done that. I accidentally had files open from two different directories this morning, apparently. |
mwcraig
added a commit
that referenced
this pull request
Sep 6, 2019
Move generation of test directory to utils
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #699 by moving generation of a sample directory out of the tests and into utils.