Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI problems #710

Merged
merged 5 commits into from Nov 28, 2019
Merged

Fix CI problems #710

merged 5 commits into from Nov 28, 2019

Conversation

MSeifert04
Copy link
Contributor

@MSeifert04 MSeifert04 commented Nov 24, 2019

It seems like we shouldn't use python: but instead use the PYTHON_VERSION variable.

I also incremented the NumPy versions (no particular reason except that we were missing NumPy 1.15 and I think that would be more appropriate than NumPy 1.13).

Closes #706

Ref: #707

@MSeifert04 MSeifert04 added this to the 2.0.2 milestone Nov 24, 2019
@MSeifert04 MSeifert04 changed the title Increment old numpy versions (experimental) Fix CI problems with old Python/NumPy versions Nov 24, 2019
@MSeifert04 MSeifert04 changed the title Fix CI problems with old Python/NumPy versions Fix CI problems Nov 24, 2019
@MSeifert04
Copy link
Contributor Author

There's one problem that needs fixing upstream (astropy/astropy#9664).

This was referenced Nov 24, 2019
@mwcraig
Copy link
Member

mwcraig commented Nov 25, 2019

This looks good except for the one we can't fix yet...

TESTED_VERSIONS)

def pytest_configure(config):
config.option.astropy_header = True
except ImportError:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should just add pytest-astropy-header as a hard dependency rather than doing this nested try except (it should ideally be picked up from pytest-astropy, but clearly something is not working as it should).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should just add pytest-astropy-header as a hard dependency

Yeah, I also thought about this. But the test-log shows that it's installed (corresponding log line from your PR) but not picked up - which makes it probably a lot harder to solve than just adding a hard-dependency.

So I would prefer the nested try-catch for now, it's only astropy-2.x after all and we may even drop support for it once the new astropy LTS is out.

Copy link
Member

@bsipocz bsipocz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would rather not do a double try/except, but don't have no strong preference to clean it up right now rather than when you remove python2 support anyway.

@MSeifert04
Copy link
Contributor Author

Should this stay open until the upstream is fixed?

Otherwise I would temporarily set the astropy-dev test to allow-fail and put this in.

@bsipocz
Copy link
Member

bsipocz commented Nov 27, 2019

I would vote for merging this (CI on master is already broken, this at least fixes some issues).

@MSeifert04
Copy link
Contributor Author

@mwcraig I'm going to merge this tomorrow if you won't object. The astropy-dev job is then (temporarily) allowed to fail.

@MSeifert04 MSeifert04 merged commit f28b94b into astropy:master Nov 28, 2019
@MSeifert04 MSeifert04 deleted the ci-numpy-versions branch November 28, 2019 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants