Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add auto-logging to ccdproc #89

Merged
merged 10 commits into from May 25, 2014
Merged

Conversation

mwcraig
Copy link
Member

@mwcraig mwcraig commented May 24, 2014

  • Auto-logging occurs in the metadata using the full function name as the key even though that isn't FITS-compliant.
  • FITS pseudo-compliance is handled by CCDData.to_hdu because that is the point at which which compliance arises.
    • Pseudo-compliance means that the keyword is shortened to 8 characters or less.
    • The value can have any length, accommodated by astropy.io.fits with the CONTINUE convention, which is not FITS-compliant but is close enough.

mwcraig added 10 commits May 24, 2014 14:38
The fatal flaw is the representation of CCDData arguments. This commit should be backed out and redone if we come up with a good way of handling this.
…ded to be used separately from cosmicray_clean
This makes the names of functions match the python-style lower case instead of FITS-style upper.
… header entries

Pseudo-compliance means it breaks no more than one FITS rule...in this case it guarantees that the keyword is 8 characters or less, allowing the CONTINUE convention to be used. If the keyword is longer than 8, HIERARCH must also be used and the two do not work together.
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.36%) when pulling 7dc19d8 on mwcraig:logging-superpowers into a2798ef on astropy:master.

mwcraig added a commit that referenced this pull request May 25, 2014
@mwcraig mwcraig merged commit 9dcf927 into astropy:master May 25, 2014
@mwcraig mwcraig deleted the logging-superpowers branch May 31, 2014 01:17
mwcraig pushed a commit to mwcraig/ccdproc that referenced this pull request Jul 18, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants