Fixes to cosmic ray tasks and closes #76, closes #57, and closes #17 #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| # Only look at the data array | ||
| if isinstance(data, np.ma.MaskedArray): | ||
| data = data.data | ||
|
|
There was a problem hiding this comment.
Is there a reason not to use the mask here?
There was a problem hiding this comment.
The masked array makes a difference to the background calculation and the median filter calculation. However, after that, individual pixels are being looked at so using a masked array doesn't make a difference. The reason to switch to mask is so that the object returned is just a normal boolean array so that it is easily integrated back into ccddata.mask. I actually struggled with this a bit as I went back and forth but think this is the best method.
|
@crawfordsm -- lookss great, just the one question above. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a number of minor fixes to the cosmic ray task to address issues #76, #57, and #17.
In
cosmicray_median, the background value has been made to match the documentation so that if None is given, the std is calculated.A test was added for gbox.
cosmicray_clean now returns a copy of the passed
ccddataobject with the data and mask values updated accordingly.