Skip to content
This repository has been archived by the owner on Aug 11, 2023. It is now read-only.

Clarify removal of DistutilsExtensionArgs in migration guide #455

Merged
merged 1 commit into from
Mar 24, 2020

Conversation

adrn
Copy link
Member

@adrn adrn commented Mar 6, 2020

I was just following the migration guide to remove astropy_helpers from one of my packages and ran into an issue that wasn't addressed in the guide: many of my setup_package.py files make use of setup_helpers.DistutilsExtensionArgs(), which appears to have been removed.

@pllim pllim requested a review from astrofrog March 6, 2020 15:25
@pllim pllim added the docs label Mar 6, 2020
@adrn
Copy link
Member Author

adrn commented Mar 17, 2020

Ping @astrofrog and @Cadair :)

Copy link
Member

@astrofrog astrofrog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@astrofrog astrofrog merged commit a177dcf into astropy:cookiecutter Mar 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants