This repository has been archived by the owner on Aug 11, 2023. It is now read-only.
add linkcheck #482
Merged
add linkcheck #482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pllim
reviewed
Oct 5, 2020
|
There is a cron example at https://github.com/astropy/astropy/blob/4bc50147063950cb43422243dcd8ac647f3abc12/.travis.yml#L71-L72 (search for "cron" on that file). Also look at https://github.com/astropy/astropy/blob/4bc50147063950cb43422243dcd8ac647f3abc12/docs/conf.py#L255 . Maybe also https://docs.travis-ci.com/user/cron-jobs/ . Thanks! 😄 |
bsipocz
reviewed
Oct 5, 2020
Closed
pllim
approved these changes
Oct 9, 2020
There was a problem hiding this comment.
LGTM. Thanks! Might want to squash the commits into one commit though.
I'll leave this open for a bit in case @astrofrog , @bsipocz , or @Cadair want to review.
add linkcheck to cron changelog Co-authored-by: P. L. Lim <2090236+pllim@users.noreply.github.com> Signed-off-by: Nathaniel Starkman <nstarkman@protonmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
.toxthere's a link check option. I've enabled this in theallow_failuressection of.travis.yml.Looking in the closed issues and PRs, I don't see anything mentioning the link check, so if this wasn't enable for a reason, I'll close this PR.
edit: I see some discussion of this in #449
Signed-off-by: Nathaniel Starkman nstarkman@protonmail.com