Skip to content

Commit

Permalink
Merge pull request #236 from cdeil/issue-236
Browse files Browse the repository at this point in the history
build_sphinx doesn't work on Python 3
  • Loading branch information
cdeil committed Jan 18, 2015
2 parents 9f15a68 + 940ff18 commit 6a23d46
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 7 deletions.
8 changes: 5 additions & 3 deletions .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,10 @@ matrix:
# may run for a long time
- python: 2.7
env: ASTROPY_VERSION=development SETUP_CMD='build_sphinx -w'
# TODO: update astropy-helpers ans add `-w` option once this has been released
# https://github.com/astropy/astropy-helpers/pull/123
- python: 3.4
env: ASTROPY_VERSION=development SETUP_CMD='build_sphinx'

# Try Astropy development version
- python: 3.3
Expand Down Expand Up @@ -112,9 +116,7 @@ install:
# - if [[ $SETUP_CMD != egg_info ]]; then $PIP_INSTALL ...; fi

# DOCUMENTATION DEPENDENCIES
# build_sphinx needs sphinx and matplotlib (for plot_directive). Note that
# this matplotlib will *not* work with py 3.x, but our sphinx build is
# currently 2.7, so that's fine
# build_sphinx needs sphinx and matplotlib (for plot_directive).
- if [[ $SETUP_CMD == build_sphinx* ]]; then $CONDA_INSTALL numpy=$NUMPY_VERSION Sphinx matplotlib; fi

# COVERAGE DEPENDENCIES
Expand Down
6 changes: 3 additions & 3 deletions ah_bootstrap.py
Original file line number Diff line number Diff line change
Expand Up @@ -304,7 +304,7 @@ def _do_download(version='', find_links=None, index_url=None):
allow_hosts = None
# Annoyingly, setuptools will not handle other arguments to
# Distribution (such as options) before handling setup_requires, so it
# is not straightfoward to programmatically augment the arguments which
# is not straightforward to programmatically augment the arguments which
# are passed to easy_install
class _Distribution(Distribution):
def get_option_dict(self, command_name):
Expand Down Expand Up @@ -405,7 +405,7 @@ def _check_submodule(path, use_git=True, offline=False):
Check if the given path is a git submodule.
See the docstrings for ``_check_submodule_using_git`` and
``_check_submodule_no_git`` for futher details.
``_check_submodule_no_git`` for further details.
"""

if use_git:
Expand Down Expand Up @@ -512,7 +512,7 @@ def _check_submodule_no_git(path):

# This is a minimal reader for gitconfig-style files. It handles a few of
# the quirks that make gitconfig files incompatible with ConfigParser-style
# files, but does not support the full gitconfig syntaix (just enough
# files, but does not support the full gitconfig syntax (just enough
# needed to read a .gitmodules file).
gitmodules_fileobj = io.StringIO()

Expand Down

0 comments on commit 6a23d46

Please sign in to comment.