Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNT: Do not write config on import #261

Merged
merged 1 commit into from
Apr 10, 2021
Merged

Conversation

pllim
Copy link
Member

@pllim pllim commented Apr 9, 2021

This functionality will be deprecated in astropy in a future release. See astropy/astropy#11497 and https://groups.google.com/g/astropy-dev/c/KVzPgeihxO8

cc @saimn

@pllim pllim requested a review from andamian April 9, 2021 22:22
@codecov
Copy link

codecov bot commented Apr 9, 2021

Codecov Report

Merging #261 (efc3571) into master (519ea28) will increase coverage by 0.08%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #261      +/-   ##
==========================================
+ Coverage   74.89%   74.98%   +0.08%     
==========================================
  Files          44       44              
  Lines        5075     5057      -18     
==========================================
- Hits         3801     3792       -9     
+ Misses       1274     1265       -9     
Impacted Files Coverage Δ
pyvo/_astropy_init.py 100.00% <ø> (+26.47%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 519ea28...efc3571. Read the comment docs.

@andamian andamian added this to the v1.2 milestone Apr 10, 2021
@andamian andamian merged commit 9fd6a42 into astropy:master Apr 10, 2021
@andamian
Copy link
Contributor

Thank you, @pllim !

@pllim pllim deleted the config-no-write branch April 10, 2021 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants