Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNT: Deprecate update_default_config and ConfigurationMissingWarning #11497

Closed
pllim opened this issue Apr 7, 2021 · 0 comments · Fixed by #11502
Closed

MNT: Deprecate update_default_config and ConfigurationMissingWarning #11497

pllim opened this issue Apr 7, 2021 · 0 comments · Fixed by #11502

Comments

@pllim
Copy link
Member

pllim commented Apr 7, 2021

This is a follow up of #10877 by @saimn . In the astropy.config subpackage, update_default_config and ConfigurationMissingWarning are no longer used within this package, but some downstream packages might still use them. There is a need to:

# This was raised with Astropy < 4.3 when the configuration file was not found.
# It is kept for compatibility and should be removed at some point.
class ConfigurationMissingWarning(AstropyWarning):

# This function is no more used by astropy but it is kept for the other
# packages that may use it (e.g. astroquery). It should be removed at some
# point.
# this is not in __all__ because it's not intended that a user uses it
def update_default_config(pkg, default_cfg_dir_or_fn, version=None, rootname='astropy'):

After this is done, open a new issue to remove them altogether from the codebase after a few more releases.

This was referenced Apr 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant