Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding session to SSAService and passing it through DatalinkService. #327

Merged
merged 2 commits into from
May 30, 2022
Merged

Adding session to SSAService and passing it through DatalinkService. #327

merged 2 commits into from
May 30, 2022

Conversation

trjaffe
Copy link
Contributor

@trjaffe trjaffe commented May 11, 2022

A cleaner PR than #293 to allow session to be passed through in SSA and DataLink as mentioned in issue #292

@codecov
Copy link

codecov bot commented May 11, 2022

Codecov Report

Merging #327 (7181c4e) into main (949693c) will not change coverage.
The diff coverage is 60.00%.

@@           Coverage Diff           @@
##             main     #327   +/-   ##
=======================================
  Coverage   75.49%   75.49%           
=======================================
  Files          44       44           
  Lines        5125     5125           
=======================================
  Hits         3869     3869           
  Misses       1256     1256           
Impacted Files Coverage Δ
pyvo/dal/adhoc.py 66.58% <0.00%> (ø)
pyvo/dal/scs.py 68.57% <100.00%> (ø)
pyvo/dal/ssa.py 56.00% <100.00%> (ø)

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@andamian andamian added the bug label May 11, 2022
@andamian andamian added this to the v1.3.1 milestone May 11, 2022
Copy link
Contributor

@tomdonaldson tomdonaldson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @trjaffe. This looks good to me as well.

pyvo/dal/scs.py Show resolved Hide resolved
@tomdonaldson tomdonaldson merged commit 6e9a963 into astropy:main May 30, 2022
tomdonaldson added a commit that referenced this pull request May 30, 2022
@bsipocz bsipocz modified the milestones: v1.3.1, v1.4 Sep 20, 2022
@bsipocz bsipocz mentioned this pull request Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants