Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tj taprecord session #447

Merged
merged 3 commits into from
Jun 2, 2023
Merged

Tj taprecord session #447

merged 3 commits into from
Jun 2, 2023

Conversation

trjaffe
Copy link
Contributor

@trjaffe trjaffe commented May 22, 2023

Fix to #446 to get TAPRecord to inherit the session from the TAPService used.

@codecov
Copy link

codecov bot commented May 22, 2023

Codecov Report

Merging #447 (d8ef6e4) into main (b5f5b37) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##             main     #447   +/-   ##
=======================================
  Coverage   80.08%   80.08%           
=======================================
  Files          52       52           
  Lines        6021     6021           
=======================================
  Hits         4822     4822           
  Misses       1199     1199           
Impacted Files Coverage Δ
pyvo/dal/tap.py 73.23% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@bsipocz bsipocz added this to the v1.5 milestone May 22, 2023
@bsipocz bsipocz modified the milestones: v1.5, v1.4.2 Jun 2, 2023
@bsipocz
Copy link
Member

bsipocz commented Jun 2, 2023

I'm doing a 1.4.2 release, and will add this to it as a trivial follow-up to #327. Ultimately it would be nice to add tests for this and #327 in a follow-up.

@bsipocz bsipocz merged commit c4f67e5 into astropy:main Jun 2, 2023
9 of 10 checks passed
bsipocz added a commit that referenced this pull request Aug 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants