Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python 3.12 testing #403

Merged
merged 7 commits into from
Oct 24, 2023
Merged

Python 3.12 testing #403

merged 7 commits into from
Oct 24, 2023

Conversation

dstansby
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Oct 19, 2023

Codecov Report

Merging #403 (ae077d5) into main (7e1dc81) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #403   +/-   ##
=======================================
  Coverage   93.60%   93.60%           
=======================================
  Files          25       25           
  Lines         891      891           
=======================================
  Hits          834      834           
  Misses         57       57           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@dstansby
Copy link
Contributor Author

Ha, so it turns out the issue isn't building the local copy of reproject, but the testing dep sunpy[map] pulling in a dependency on reproject, and trying to download and build the latest released verision from PyPI, which doesn't compile under Python 3.12...

@dstansby
Copy link
Contributor Author

So I think the best way round this is to not test with sunpy on Python 3.12, until a release of reproject has been done with Python 3.12 to PyPI. I can't see another good way to avoid the sunpy test dependency trying to pull in a version of reproject from PyPI that is incompatible with Python 3.12.

Copy link
Member

@astrofrog astrofrog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@astrofrog astrofrog merged commit 124a9cd into astropy:main Oct 24, 2023
22 of 23 checks passed
@dstansby dstansby deleted the py312 branch October 24, 2023 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants