Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add testing on Python 3.12 #402

Merged
merged 4 commits into from
Oct 24, 2023
Merged

Add testing on Python 3.12 #402

merged 4 commits into from
Oct 24, 2023

Conversation

astrofrog
Copy link
Member

Re-opened #399

I added a commit to use pre-releases on Python 3.12 to pick up an aiohttp pre-release

@codecov
Copy link

codecov bot commented Oct 19, 2023

Codecov Report

Merging #402 (02d3a04) into main (7e1dc81) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #402   +/-   ##
=======================================
  Coverage   93.60%   93.60%           
=======================================
  Files          25       25           
  Lines         891      891           
=======================================
  Hits          834      834           
  Misses         57       57           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@astrofrog
Copy link
Member Author

@dstansby - looks like this is now failing with real Python 3.12-related compilation issues

@dstansby
Copy link
Contributor

Let me have a play, might open a new PR from my own branch so I can push to it

@dstansby
Copy link
Contributor

Waiting for tests to run, but think I've come up with a solution at #403

@astrofrog astrofrog merged commit 02d3a04 into astropy:main Oct 24, 2023
22 of 62 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants