-
-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow tests that perform remote data access to be disabled #401
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is still one remote access in docs/index.rst:
045 >>> from astropy.io import fits
046 >>> from astropy import units as u
047 >>> import numpy as np
048 >>> from matplotlib import pyplot as plt
049 >>> from astropy.visualization import quantity_support
050 >>> quantity_support() # for getting units on the axes below # doctest: +IGNORE_OUTPUT
051
052 Now we load the dataset from it's canonical source:
053
054 >>> f = fits.open('https://dr14.sdss.org/optical/spectrum/view/data/format=fits/spec=lite?plateid=1323&mjd=5279
UNEXPECTED EXCEPTION: URLError(gaierror(-3, 'Temporary failure in name resolution'),)
T
fc22eb1
to
29dbb14
Compare
fd5ca40
to
d5396cf
Compare
d5396cf
to
fd09440
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can confirm that this ran correctly for me locally.
@olebole do you have a chance to test this again? |
Yes, I can confirm it works for me. Thank you for the fix. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works for me.
This makes use of the pytest-remotedata plugin in order to control tests that require access to remote data. By default all tests will run, including those that access remote data. To disable this, pass
--remote-data=none
to thepytest
command.This means that
pytest-remotedata
is now a test dependency.This resolves #399. cc @olebole