Added PFS object loader. Closes astropy/specutils#430 #431
Conversation
There was a problem hiding this comment.
Mostly looks good to me, although caveat it might be good to address #450 for this loader in this PR (instead of waiting for this to get merged).
Might be good to get a once-over by @SaOgaz, @drdavella or someone else who's worked with the loaders more than I, though?
| _spec_pattern.match(args[0]) is not None) | ||
|
|
||
|
|
||
| @data_loader(label="pfsObject", identifier=spec_identify, extensions=['fits']) |
There was a problem hiding this comment.
Maybe this should be subaru_pfsObject? "PFS" is unfortunately a bit overloaded of a term now...
| from specutils import Spectrum1D | ||
|
|
||
| __all__ = ['spec_identify', 'spec_loader'] | ||
|
|
There was a problem hiding this comment.
It would be great to get a comment here with a description of what this RE matching is doing. Doesn't have to be super de-tailed, maybe just a couple examples of matching strings.
| """ | ||
| m = _spec_pattern.match(os.path.basename(file_name)) | ||
|
|
||
| hdulist = fits.open(file_name, **kwargs) |
There was a problem hiding this comment.
Change this to a with hdulist as fits.open()?
|
Thanks for addressing all of this, @gpernot - all looks good to me, so merging! |
No description provided.