Fix bug in creation of default identifiers for data loaders #447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nmearl
approved these changes
Feb 14, 2019
|
I believe this should also solve spacetelescope/specviz#672. |
drdavella
commented
Feb 14, 2019
drdavella
force-pushed
the
fix-default-loader
branch
from
4438102
to
f807bc3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this PR, if no identifier or list of compatible extensions was provided to the
data_loaderdecorator, then an invalid identifier would be created. This fixes that bug and also adds more informative output for these cases.It's worth noting that
specviznow expects all loaders to have identifiers. So if a user creates a custom loader that has neither an explicit identifier nor a list of compatible extensions, it will not be possible to load the associated files usingspecviz.We may want to consider adding an optional argument to
data_loaderthat automatically creates a dummy identifier that positively identifies all files.Thanks @nluetzge for providing the original bug report.