Add in propagation of error for convolution smoothing #486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@crawfordsm if you could take a quick look at this... |
SaOgaz
approved these changes
Jul 24, 2019
|
@eteq Could you take a look at this old PR? |
eteq
requested changes
Sep 13, 2019
There was a problem hiding this comment.
Looking pretty solid, @brechmos-stsci . Mostly just a few doc clarifications, but one substansive code bit - see the last inline comment.
brechmos-stsci
force-pushed
the
fix-251-uncertainty-convolution
branch
from
cba098e
to
406fff2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds in the propagation of error (uncertainty) using a standard propagation of error definition. Tests and documentation were added too.
This does not include covariance between spaxels and is noted in the code and docs.
Fixes #251