Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix asdf extension url mapping bug #500

Merged
merged 2 commits into from
Aug 7, 2019
Merged

Conversation

jdavies-st
Copy link
Contributor

Fixes #465.

Also:

  • Moves the asdf pytest schema tester into the top-level conftest.py. pytest>=4 requires that plugins be specified only at the top level. This will re-enable the testing of ASDF schemas.
  • Will use the schema tester via entry_points if available (currently in dev in asdf).

@nden
Copy link
Contributor

nden commented Aug 4, 2019

This was failing with asdf on master, right? Could you add scipy to the Travis job testing with DEV versions. All DEV tests are currently failing because scipy is missing.

@jdavies-st
Copy link
Contributor Author

Updated TravisCI dev matrix.

This wasn't failing on asdf master. It was interfering with asdf mappings. I've captured that behavior in the included test so it won't happen again.

@nmearl
Copy link
Contributor

nmearl commented Aug 6, 2019

This looks really great, @jdavies-st! Thank you! Can you squash those last two commits? Then I think it's ready to merge in!

@jdavies-st
Copy link
Contributor Author

Squashed/rebased. Looks like the allowed failure on Travis with dev versions of asdf and gwcs is still failing. I will throw some commits at it.

@nden
Copy link
Contributor

nden commented Aug 6, 2019

The dev failures (or some of them) are resolved in #490. It's a chicken and egg. That one is failing because of the asdf problem. It's probably best to merge this one and then finish #490.

@jdavies-st
Copy link
Contributor Author

I see. That makes sense.

Could someone kick the tires on the Travis build? Restart it?

Lots of problems with remote data and apt-get installs this week on Travis for some reason.

@nmearl
Copy link
Contributor

nmearl commented Aug 7, 2019

This is looking good. @jdavies-st is this ready to merge now?

@jdavies-st
Copy link
Contributor Author

Yes, merge away.

@nmearl nmearl merged commit f65c8ae into astropy:master Aug 7, 2019
@jdavies-st jdavies-st deleted the asdf-extension branch January 23, 2020 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SpecutilsExtension ASDF extension interferes with url_mapping of other ASDF extensions (astropy, jwst)
3 participants