Raise exception when spectral and flux axes have different lengths #508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nmearl
suggested changes
Sep 6, 2019
nmearl
approved these changes
Sep 9, 2019
|
Just a note on the docs/diagnostics: the error message now states "must be the same (or uncertainty must be a singleton", but a length-1 or scalar |
nmearl
reviewed
Sep 9, 2019
specutils/spectra/spectrum1d.py
Outdated
| @@ -112,6 +118,12 @@ def __init__(self, flux=None, spectral_axis=None, wcs=None, | |||
| data=flux.value if isinstance(flux, u.Quantity) else flux, | |||
| wcs=wcs, **kwargs) | |||
|
|
|||
| if hasattr(self, 'uncertainty') and self.uncertainty is not None: | |||
| if not flux.shape == self.uncertainty.array.shape: | |||
| raise ValueError('Flux axis ({}) and uncertainty ({}) shapes must be the same (or uncertainty must be a singleton)'.format( | |||
There was a problem hiding this comment.
Suggested change
| raise ValueError('Flux axis ({}) and uncertainty ({}) shapes must be the same (or uncertainty must be a singleton)'.format( | |
| raise ValueError('Flux axis ({}) and uncertainty ({}) shapes must be the same.'.format( |
eteq
approved these changes
Sep 9, 2019
There was a problem hiding this comment.
One minor suggestion but otherwise this looks good to me.
Note: I'm approving to indicate "I like it overall, and don't need to see it again unless someone wants more feedback from me", but the inline comment is meant to mean "don't merge without the comment either being accepting or intentionally rejected" (i.e., if there's a good reason not to be doing this then that's fine).
Co-Authored-By: Erik Tollerud <erik.tollerud@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will check the spectral_axis and flux axis lengths to make sure they are the same and will raise an exception if that is not the case.
Fixes #326