Add travis stages and other cleanups #515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bsipocz
force-pushed
the
travis_stages
branch
from
6419131
to
2006f72
Compare
bsipocz
force-pushed
the
travis_stages
branch
from
c8b1a4c
to
42632d7
Compare
|
Hmm, why is this passing even with a failing test? |
|
That job was allowed to fail. For upstream it would be very useful to not let it fail, but it's up to you. |
nmearl
approved these changes
Sep 23, 2019
|
It may make sense to put the allowed failures to a separate stage that is only run when everything else passes? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to close #514
I haven't really updated the version combinations in the matrix to be the most comprehensive, but added a weekly cron that will run on the astropy dev job as that's a valuable way to provide feedback of failures upstream while they are still in the dev cycle.