Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement spectral coordinate object #524

Merged
merged 54 commits into from
Mar 18, 2020
Merged

Implement spectral coordinate object #524

merged 54 commits into from
Mar 18, 2020

Commits on Sep 24, 2019

  1. Implement spectral coordinate object

    @nmearl
    nmearl committed Sep 24, 2019
    Configuration menu
    Copy the full SHA
    d8d282d View commit details
    Browse the repository at this point in the history

Commits on Oct 14, 2019

  1. Minor changes to frame transformation behavior

    @nmearl
    nmearl committed Oct 14, 2019
    Configuration menu
    Copy the full SHA
    c933563 View commit details
    Browse the repository at this point in the history

Commits on Oct 15, 2019

  1. Tweak projection calculation; differentiate rv handling

    @nmearl
    nmearl committed Oct 15, 2019
    Configuration menu
    Copy the full SHA
    2311176 View commit details
    Browse the repository at this point in the history

Commits on Oct 16, 2019

  1. Fix unit inheritance on subclass

    @nmearl
    nmearl committed Oct 16, 2019
    Configuration menu
    Copy the full SHA
    45fd076 View commit details
    Browse the repository at this point in the history

Commits on Nov 14, 2019

  1. Started adding general SkyCoord tests

    @astrofrog
    astrofrog committed Nov 14, 2019
    Configuration menu
    Copy the full SHA
    ca592ea View commit details
    Browse the repository at this point in the history

  2. Make __init__ of SpectralCoord use keyword-only arguments

    @astrofrog
    astrofrog committed Nov 14, 2019
    Configuration menu
    Copy the full SHA
    909d964 View commit details
    Browse the repository at this point in the history

  3. Refactored/tidied up test for initialization with observer and target

    @astrofrog
    astrofrog committed Nov 14, 2019
    Configuration menu
    Copy the full SHA
    2093f04 View commit details
    Browse the repository at this point in the history

  4. Improvements to test

    @astrofrog
    astrofrog committed Nov 14, 2019
    Configuration menu
    Copy the full SHA
    08e98fd View commit details
    Browse the repository at this point in the history

  5. Pass the assertion for now

    @astrofrog
    astrofrog committed Nov 14, 2019
    Configuration menu
    Copy the full SHA
    530484c View commit details
    Browse the repository at this point in the history

  6. Remove incorrect assert

    @astrofrog
    astrofrog committed Nov 14, 2019
    Configuration menu
    Copy the full SHA
    2fa95de View commit details
    Browse the repository at this point in the history

Commits on Nov 18, 2019

  1. check rv/redshift for near-to-far cases

    @eteq
    eteq committed Nov 18, 2019
    Configuration menu
    Copy the full SHA
    58578fd View commit details
    Browse the repository at this point in the history

  2. add shifting tests

    @eteq
    eteq committed Nov 18, 2019
    Configuration menu
    Copy the full SHA
    8c503be View commit details
    Browse the repository at this point in the history

Commits on Nov 19, 2019

  1. implement assert_frame_allclose

    @eteq
    eteq committed Nov 19, 2019
    Configuration menu
    Copy the full SHA
    8d9e01c View commit details
    Browse the repository at this point in the history

  2. typo fix

    @eteq
    eteq committed Nov 19, 2019
    Configuration menu
    Copy the full SHA
    6038c18 View commit details
    Browse the repository at this point in the history

Commits on Nov 20, 2019

  1. Include setter class instance checks

    @nmearl
    nmearl committed Nov 20, 2019
    Configuration menu
    Copy the full SHA
    59b977c View commit details
    Browse the repository at this point in the history

  2. None checks in rv and redshift properties

    @nmearl
    nmearl committed Nov 20, 2019
    Configuration menu
    Copy the full SHA
    3edb5b8 View commit details
    Browse the repository at this point in the history

  3. Include redshift and radial velocity in arguments; add new properties

    @nmearl
    nmearl committed Nov 20, 2019
    Configuration menu
    Copy the full SHA
    82f283c View commit details
    Browse the repository at this point in the history

  4. update radial_velocity_correction test to work

    @eteq
    eteq committed Nov 20, 2019
    Configuration menu
    Copy the full SHA
    9d1a511 View commit details
    Browse the repository at this point in the history

Commits on Nov 29, 2019

  1. Fix rv calculation when rv is explicitly provided

    @nmearl
    nmearl committed Nov 29, 2019
    Configuration menu
    Copy the full SHA
    c4a4ecc View commit details
    Browse the repository at this point in the history

Commits on Dec 6, 2019

  1. Passing science case tests with None implementation

    @nmearl
    nmearl committed Dec 6, 2019
    Configuration menu
    Copy the full SHA
    c03efaf View commit details
    Browse the repository at this point in the history

Commits on Feb 26, 2020

  1. Implicitly create observer/target pairs

    @nmearl
    nmearl committed Feb 26, 2020
    Configuration menu
    Copy the full SHA
    a6bcd46 View commit details
    Browse the repository at this point in the history

  2. Fix incorrect asserts for default observer/target case

    @nmearl
    nmearl committed Feb 26, 2020
    Configuration menu
    Copy the full SHA
    e123b5f View commit details
    Browse the repository at this point in the history

  3. Avoid issue with astropy Galactic coordinates

    @nmearl
    nmearl committed Feb 26, 2020
    Configuration menu
    Copy the full SHA
    138c4ce View commit details
    Browse the repository at this point in the history

  4. Try composing default frame objects more robust

    @nmearl
    nmearl committed Feb 26, 2020
    Configuration menu
    Copy the full SHA
    fe18146 View commit details
    Browse the repository at this point in the history

  5. Remove numpy compat imports

    @nmearl
    nmearl committed Feb 26, 2020
    Configuration menu
    Copy the full SHA
    b3f1703 View commit details
    Browse the repository at this point in the history

  6. Revamp based on discussions in astropy#422

    @nmearl
    nmearl committed Feb 26, 2020
    Configuration menu
    Copy the full SHA
    9350deb View commit details
    Browse the repository at this point in the history

  7. Clean up class object creation; get tests passing

    @nmearl
    nmearl committed Feb 26, 2020
    Configuration menu
    Copy the full SHA
    81350ff View commit details
    Browse the repository at this point in the history

  8. Avoid validation on None inputs

    @nmearl
    nmearl committed Feb 26, 2020
    Configuration menu
    Copy the full SHA
    a71ed1a View commit details
    Browse the repository at this point in the history

  9. Maintain hidden reference to implicity frames

    @nmearl
    nmearl committed Feb 26, 2020
    Configuration menu
    Copy the full SHA
    3bc2124 View commit details
    Browse the repository at this point in the history

  10. Update tests to properly handle rv/z

    @nmearl
    nmearl committed Feb 26, 2020
    Configuration menu
    Copy the full SHA
    db0461d View commit details
    Browse the repository at this point in the history

Commits on Mar 3, 2020

  1. Fix mock target creation when target not provided

    @nmearl
    nmearl committed Mar 3, 2020
    Configuration menu
    Copy the full SHA
    c1f6e0c View commit details
    Browse the repository at this point in the history

  2. Include simple methods for updating rv/redshift

    @nmearl
    nmearl committed Mar 3, 2020
    Configuration menu
    Copy the full SHA
    cd1385e View commit details
    Browse the repository at this point in the history

Commits on Mar 10, 2020

  1. Replacing remaining rest reference

    @nmearl
    nmearl committed Mar 10, 2020
    Configuration menu
    Copy the full SHA
    4b387d4 View commit details
    Browse the repository at this point in the history

  2. Update equivalency handling in override

    @nmearl
    nmearl committed Mar 10, 2020
    Configuration menu
    Copy the full SHA
    7e0dc4a View commit details
    Browse the repository at this point in the history

Commits on Mar 15, 2020

  1. switch keck to example site

    @eteq
    eteq committed Mar 15, 2020
    Configuration menu
    Copy the full SHA
    8b512a0 View commit details
    Browse the repository at this point in the history

  2. initialization of asteroid case

    @eteq
    eteq committed Mar 15, 2020
    Configuration menu
    Copy the full SHA
    e6f9528 View commit details
    Browse the repository at this point in the history

  3. complete test_asteroid_velocity_frame_shifts

    @eteq
    eteq committed Mar 15, 2020
    Configuration menu
    Copy the full SHA
    9e236c6 View commit details
    Browse the repository at this point in the history

  4. implement misc tests of rv/redshift/init behavior

    @eteq
    eteq committed Mar 15, 2020
    Configuration menu
    Copy the full SHA
    f682236 View commit details
    Browse the repository at this point in the history

  5. add test_los_shift

    @eteq
    eteq committed Mar 15, 2020
    Configuration menu
    Copy the full SHA
    e2c9b51 View commit details
    Browse the repository at this point in the history

Commits on Mar 16, 2020

  1. Update redshift radial velocity equivalency

    @nmearl
    nmearl committed Mar 16, 2020
    Configuration menu
    Copy the full SHA
    886bcac View commit details
    Browse the repository at this point in the history

  2. Break out target creation into separate method

    @nmearl
    nmearl committed Mar 16, 2020
    Configuration menu
    Copy the full SHA
    5c4a418 View commit details
    Browse the repository at this point in the history

  3. If rv exists, assign on coordinate validation

    @nmearl
    nmearl committed Mar 16, 2020
    Configuration menu
    Copy the full SHA
    993ba98 View commit details
    Browse the repository at this point in the history

  4. Re-create implicit target when setting observer

    @nmearl
    nmearl committed Mar 16, 2020
    Configuration menu
    Copy the full SHA
    88efe4c View commit details
    Browse the repository at this point in the history

  5. Fix position normalization in rv calculation

    @nmearl
    nmearl committed Mar 16, 2020
    Configuration menu
    Copy the full SHA
    e9853e3 View commit details
    Browse the repository at this point in the history

  6. Update redshift and rv tests for spectral coord

    @nmearl
    nmearl committed Mar 16, 2020
    Configuration menu
    Copy the full SHA
    62e03fb View commit details
    Browse the repository at this point in the history

Commits on Mar 17, 2020

  1. Fix los shift behavior

    @nmearl
    nmearl committed Mar 17, 2020
    Configuration menu
    Copy the full SHA
    8903e6f View commit details
    Browse the repository at this point in the history

  2. Move projection and norm calculations into methods

    @nmearl
    nmearl committed Mar 17, 2020
    Configuration menu
    Copy the full SHA
    708aedf View commit details
    Browse the repository at this point in the history

  3. Fix basic behavior test for rv calcs with target

    @nmearl
    nmearl committed Mar 17, 2020
    Configuration menu
    Copy the full SHA
    b9076ea View commit details
    Browse the repository at this point in the history

  4. Update method calls

    @nmearl
    nmearl committed Mar 17, 2020
    Configuration menu
    Copy the full SHA
    e8dac62 View commit details
    Browse the repository at this point in the history

  5. Allow auto creation of observer from target

    @nmearl
    nmearl committed Mar 17, 2020
    Configuration menu
    Copy the full SHA
    5e4ff5f View commit details
    Browse the repository at this point in the history

  6. Handle lack of precision in projection calculation

    @nmearl
    nmearl committed Mar 17, 2020
    Configuration menu
    Copy the full SHA
    b150078 View commit details
    Browse the repository at this point in the history

  7. Properly transform frames in differentials update

    @nmearl
    nmearl committed Mar 17, 2020
    Configuration menu
    Copy the full SHA
    633f01c View commit details
    Browse the repository at this point in the history

  8. Include tolerance in rv allclose check

    @nmearl
    nmearl committed Mar 17, 2020
    Configuration menu
    Copy the full SHA
    9259a80 View commit details
    Browse the repository at this point in the history

  9. Fix final review comments

    @nmearl
    nmearl committed Mar 17, 2020
    Configuration menu
    Copy the full SHA
    691a68d View commit details
    Browse the repository at this point in the history